Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Windows: do not resolve files in current working dir if CWD is not explicitly in PATH. #884

Merged
merged 4 commits into from
Nov 5, 2020

Conversation

gtardif
Copy link
Contributor

@gtardif gtardif commented Nov 5, 2020

Workaround for golang/go#38736

Signed-off-by: guillaume.tardif [email protected]

What I did

  • duplicate window os/exec.LookPath() and removed resolving current working dir before resolving in PATH

Related issue

/test-windows

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@gtardif gtardif requested a review from chris-crone November 5, 2020 15:30
@github-actions github-actions bot added the cli cli label Nov 5, 2020
Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/mobycli/lp_unix.go Outdated Show resolved Hide resolved
…ent working dir if CWD is not explicitly in PATH.

Signed-off-by: guillaume.tardif <[email protected]>
@gtardif gtardif force-pushed the win_fix_execute_working_dir branch from 0e98594 to 4489f39 Compare November 5, 2020 15:43
cli/mobycli/exec.go Outdated Show resolved Hide resolved
@gtardif gtardif force-pushed the win_fix_execute_working_dir branch from f3b3259 to da09c9c Compare November 5, 2020 16:32
@gtardif gtardif force-pushed the win_fix_execute_working_dir branch from da09c9c to 66a1263 Compare November 5, 2020 16:38
@gtardif gtardif merged commit c1ee51f into main Nov 5, 2020
@gtardif gtardif deleted the win_fix_execute_working_dir branch November 5, 2020 17:05
RonSherfey

This comment was marked as spam.

@docker-archive docker-archive deleted a comment from budvajda Nov 24, 2021
hibitchbye

This comment was marked as spam.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants